[PATCH] D81227: Correctly report modified status for GCOVProfiling

[calixte via Phabricator via llvm-commits]

calixte added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp:572
+  if (Options.EmitData) emitProfileArcs();
+  return true; // Because of the added flush.
 }
----------------
My bad...
Anyway there is some extra flush/dump only if there are some fork/exec*.
So if I understand correctly the purpose of the returned boolean, you need to check if a flush/dump has been added or not and check if emitProfileArcs changed something and return a OR on these two values.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81227/new/

https://reviews.llvm.org/D81227