[PATCH] D80860: Exact integer emptiness checks for FlatAffineConstraints

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: mlir/lib/Analysis/Presburger/Simplex.cpp:627
+    llvm::SmallVector<int64_t, 32> coeffs;
+    for (unsigned i = 0; i < dir.size(); i++)
+      coeffs.emplace_back(dir[i]);
----------------
ftynse wrote:
> Don't evaluate the exit condition on every iteration, use
> 
> for (unsigned i = 0, e = dir.size(); i < e; ++i)
or better with range-style: `for (int i : llvm::seq<int>(dir.size()))` :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80860/new/

https://reviews.llvm.org/D80860