[PATCH] D81145: [MC] Generate a compilation unit in the 64-bit DWARF format [3/7]

Thu Jun 4 20:24:05 PDT 2020

dblaikie added a comment.

In D81145#2075135 <https://reviews.llvm.org/D81145#2075135>, @probinson wrote:

> In D81145#2074793 <https://reviews.llvm.org/D81145#2074793>, @dblaikie wrote:
>
> > In D81145#2074692 <https://reviews.llvm.org/D81145#2074692>, @probinson wrote:
> >
> > > This patch is for generating DWARF-64 format for raw assembler source.  Why is that an interesting case?  I could see wanting to emit a .debug_info section for higher level languages in DWARF-64 format, but that is not what this patch does.
> >
> >
> > Might be best to keep the fundamental design direction/question here in one thread ( https://reviews.llvm.org/D81144 ) rather than in all of them. Patches are in a series, so if that one ends up going another direction I don't think there's a risk these later ones will be reviewed/approved/committed in spite of that fundamental question.
>
>
> Okay, but is the idea that this patch handles both asm source and the normal case?  Because I don't think it does.

Nope, the LLVM IR support should be in a separate patch - that'll be in llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp - llvm::DwarfUnit::emitCommonHeader, for instance. And other support through lib/CodeGen/AsmPrinter for the form encoding length, etc.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81145/new/

https://reviews.llvm.org/D81145