[PATCH] D81205: [dsymutil] Don't emit N_AST symbol entries in the Mach-O companion file
Jonas Devlieghere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 4 17:09:23 PDT 2020
JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.
================
Comment at: llvm/tools/dsymutil/MachOUtils.cpp:167
+ // Do not transfer AST or OSO symbols as they're only needed by dsymutil.
+ if (NList.n_type == MachO::N_AST || NList.n_type == MachO::N_OSO)
+ return false;
----------------
Previously the code below would filter out `N_OSO` entries, relying on the fact that `N_OSO` entries come after `N_SO` entries. That means that technically the `N_OSO` could be omitted here, but I think this is much clearer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81205/new/
https://reviews.llvm.org/D81205
More information about the llvm-commits
mailing list