[PATCH] D81198: [docs] Specify rules for updating debug locations

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 4 16:04:05 PDT 2020


echristo added subscribers: cmtice, tbosch, echristo.
echristo added a reviewer: echristo.
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

This is really awesome to write up! One inline request for some elaboration, but otherwise I'm happy with this. For the record I was contemplating asking for more specifics under when to drop or moving the bits for merging down... but I'm not entirely sure that's better, just different :)

-eric



================
Comment at: llvm/docs/HowToUpdateDebugInfo.rst:86-87
+
+* Speculative execution of *different* instructions from both sides of a CFG
+  diamond. The rule for :ref:`dropping locations<WhenToDropLocation>` applies.
+
----------------
Bit more clarification here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81198/new/

https://reviews.llvm.org/D81198





More information about the llvm-commits mailing list