[PATCH] D80599: [HWASan] Add sizeof(global) in report even if symbols missing.

Thu Jun 4 14:57:27 PDT 2020

hctim updated this revision to Diff 268596.
hctim marked 2 inline comments as done.
hctim added a comment.

- Fix up phdr iteration and correctly find the load bias.

As it turns out, dli_fbase returned by dladdr() and dlpi_addr by dl_iterate_phdr both call themselves "base address", but are different things. Absolutely did my head in.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80599/new/

https://reviews.llvm.org/D80599

Files:
  compiler-rt/lib/hwasan/CMakeLists.txt
  compiler-rt/lib/hwasan/hwasan.cpp
  compiler-rt/lib/hwasan/hwasan_globals.cpp
  compiler-rt/lib/hwasan/hwasan_globals.h
  compiler-rt/lib/hwasan/hwasan_report.cpp
  compiler-rt/lib/sanitizer_common/sanitizer_common.h
  compiler-rt/test/hwasan/TestCases/global.c
  llvm/utils/gn/secondary/compiler-rt/lib/hwasan/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80599.268596.patch
Type: text/x-patch
Size: 16944 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200604/cc5313b8/attachment.bin>