[PATCH] D81147: [MC] Generate .debug_rnglists in the 64-bit DWARF format [5/7]

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/MC/MCDwarf.cpp:1023
     // start of the .debug_ranges/.debug_rnglists.
-    MCOS->emitSymbolValue(RangesSymbol, 4);
+    MCOS->emitSymbolValue(RangesSymbol, OffsetSize);
   } else {
----------------
probinson wrote:
> This function (EmitGenDwarfInfo) is for emitting DWARF to describe raw assembler source, which I believe is not really the interesting case.
Might be best to keep the fundamental design direction/question here in one thread ( https://reviews.llvm.org/D81144 ) rather than in all of them. Patches are in a series, so if that one ends up going another direction I don't think there's a risk these later ones will be reviewed/approved/committed in spite of that fundamental question.


================
Comment at: llvm/test/MC/ELF/gen-dwarf64.s:50-51
+# DUMP5:      .debug_rnglists contents:
+# DUMP5-NEXT: 0x00000000: range list header:
+# DUMP5-SAME:   format = DWARF64
+# DUMP5-NEXT: ranges:
----------------
Test the length is correct, since this patch changes how it's emitted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81147/new/

https://reviews.llvm.org/D81147