[PATCH] D80794: [flang] Fix release build flags.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

The `CMAKE_XYZ_FLAGS` are supposed to be in control by the user, not by the project. Modifying them in the CMakeLists.txt is an anti-pattern. It has global effects, that is `-DDEBUGF18` will be added to all LLVM projects in debug builds, not just flang. Did you consider using `add_compile_definitions` or `target_compile_definitions` instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80794/new/

https://reviews.llvm.org/D80794