[PATCH] D81144: [MC] Generate .debug_line in the 64-bit DWARF format [2/7]

Thu Jun 4 14:23:49 PDT 2020

dblaikie added a comment.

In D81144#2074668 <https://reviews.llvm.org/D81144#2074668>, @probinson wrote:

> The test is verifying that llvm-mc can emit a DWARF-64 line table describing assembler source that does not have any .loc directives in it.  That's not really the interesting case; the interesting case is assembler source that *does* have .loc directives in it, because that's the path that most compilations will actually use.  Describing assembler source really doesn't need to support DWARF-64.

I think it's a useful place to start for consistency & testing - I get where you're coming from with regards to the features of MC DWARF support that are only needed for assembly DWARF not needed for higher level source DWARF - but they seem to me small enough to implement & nice to have for consistency. (I guess some people might turn on DWARF64 for their whole build if they really want it - and who knows, maybe they are generating weirdly massive assembly files that justify/need DWARF64)

> Note that within the MCDwarf arena, "GenDwarf" generally refers to DWARF generated to describe assembler source, rather than DWARF describing other source that simply happens to be passing through the assembler phase.  Therefore I think a test named "gen-dwarf64.s" would be somewhat misleading to people familiar with this area.  Please use a different name for your test.

This is the foundational test that other patches that flesh out the MC DWARF support are adding to, so I think the name fits.

(not meaning to cutoff discussion - just my 2c)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81144/new/

https://reviews.llvm.org/D81144