[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

[Mike Rice via Phabricator via llvm-commits]

mikerice added a comment.

Is it possible to have the same problem with other directives, like 'omp single' or 'omp master'?  I haven't seen any test fail for those yet though.



================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:357
   ///        should be called.
+  /// \param WithMemBarrier true if the memory fence instructios are required to
+  /// prevent optimizations.
----------------
instructions


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:380
   /// should        be called.
+  /// \param WithMemBarrier true if the memory fence instructios are required to
+  /// prevent optimizations.
----------------
instructions


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81192/new/

https://reviews.llvm.org/D81192