[PATCH] D79936: [FileCheck] Add function call support to numerical expressions.

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 4 13:51:12 PDT 2020


paulwalker-arm marked an inline comment as done.
paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Support/FileCheck.cpp:629
+  while (!Expr.empty() && !Expr.startswith(")")) {
+    Expr = Expr.rtrim(SpaceChars);
+    if (Expr.startswith(","))
----------------
arichardson wrote:
> Should this be ltrim?
It looks like redundant code as space is already trimmed before loop entry and exit. I'll remove it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79936/new/

https://reviews.llvm.org/D79936





More information about the llvm-commits mailing list