[PATCH] D80377: [flang] Google test infrastructure support for unittests

[sameeran joshi via Phabricator via llvm-commits]

sameeranjoshi marked an inline comment as done.
sameeranjoshi added inline comments.


================
Comment at: flang/runtime/io-error.cpp:10
 #include "io-error.h"
-#include "config.h"
 #include "magic-numbers.h"
----------------
tskeith wrote:
> sameeranjoshi wrote:
> > tskeith wrote:
> > > Is this supposed to be part of your change?
> > Yes, out-of-tree builds fail with this include.
> > Also see this commit addressing the same
> > https://github.com/flang-compiler/f18-llvm-project/commit/4069068c997812c1c8ef6434a5e630603c7232e0
> > 
> This should be in a separate change. It has nothing to do with google test infrastructure.
> 
> The include of config.h was added for a reason. Does that reason no longer apply or are you breaking something else by changing this?
I could build and test successfully with removing this file for out of tree and in tree.
Can you mention what does "something else" mean here or for what specific reason was this added ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80377/new/

https://reviews.llvm.org/D80377