[PATCH] D81188: [RISCV] Support experimental v extensions.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: clang/test/Driver/riscv-arch.c:364
+
+// RUN: %clang -target riscv32-unknown-elf -march=rv32iv -### %s \
+// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-EXPERIMENTAL-V-NOFLAG %s
----------------
For the RUN lines, I'd prefer the suggestion in https://reviews.llvm.org/D80838?id=267971#inline-744878

You replace -fsyntax-only to -c if it is too long.



================
Comment at: clang/test/Driver/riscv-arch.c:379
+
+// RUN: %clang -target riscv32-unknown-elf -march=rv32iv0p8 -menable-experimental-extensions -### %s \
+// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-EXPERIMENTAL-V-GOODVERS %s
----------------
Should there be a p7 test? Along with a p8 test, we can know that p8 is the split line.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81188/new/

https://reviews.llvm.org/D81188