[PATCH] D81097: [llvm-objcopy] Reorder --dump-section before --remove-section for ELF.
Alexander Shaposhnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 4 13:16:15 PDT 2020
alexshap added inline comments.
================
Comment at: llvm/test/tools/llvm-objcopy/ELF/dump-section-before-add-remove.test:9
+# RUN: llvm-objcopy --dump-section .test2=%t1 -R .test2 %t %t2
+# RUN: od -t x1 %t1 | FileCheck %s --ignore-case --match-full-lines
+
----------------
nit: to me it's somehow easier to read the test when the "check:" lines follow the corresponding invocations:
```
# RUN: llvm-objcopy ...
# RUN: llvm-objdump %t | FileCheck %s
# CHECK: Expected line 1
# CHECK: Expected line 2
!ELF
FileHeader:
Class: ...
```
not sure how it compares with what @MaskRay mentioned above, I do not have a strong opinion regarding this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81097/new/
https://reviews.llvm.org/D81097
More information about the llvm-commits
mailing list