[PATCH] D81110: [Support] Move color handling from raw_fd_ostream to raw_ostream

[Pavel Labath via Phabricator via llvm-commits]

labath added a comment.

In D81110#2074372 <https://reviews.llvm.org/D81110#2074372>, @JDevlieghere wrote:

> Implement a variation of Pavel's suggestion. I've added a method called `use_color()` which computer whether we should use colors are not. I hope the inline comments are sufficiently self-explanatory.


Those comments are fine, but can you elaborate on the intended relationship between `use_color`, `has_colors` and `enable_colors`? I'm not sure those are entirely consistent. In particular, the fact that `raw_string_ostream::has_colors` returns true seems to be in contradiction with the comment on that method in the base class: "This function determines if this stream is displayed and supports colors."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81110/new/

https://reviews.llvm.org/D81110