[PATCH] D75509: [mlir] Removed TanHOp lowering from ConvertStandardToLLVM since there is no reasonable TanH representation in LLVM.

[Lubomir Litchev via Phabricator via llvm-commits]

llitchev added a comment.
Herald added subscribers: msifontes, jurahul, Kayjukh, frgossen, grosul1, stephenneuendorffer.
Herald added a reviewer: ftynse.
Herald added a project: MLIR.

Hello! I am confused about the reasoning why this functionality was removed - we certainly need the it. I did coded up pretty much the same change and someone (thanks Laub, Frank) pointed out this diff. What is the general strategy/approach to lower operations that are not intrinsics in the LLVM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75509/new/

https://reviews.llvm.org/D75509