[PATCH] D80769: [WebAssembly] Adding 64-bit versions of all load & store ops.
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 4 12:09:38 PDT 2020
sbc100 added inline comments.
================
Comment at: llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyWasmObjectWriter.cpp:95
case WebAssembly::fixup_uleb128_i32:
+ case WebAssembly::fixup_uleb128_i64:
if (SymA.isGlobal())
----------------
Might be worth a separate case for fixup_sleb128_i64 since we know they can only be memory addresses.
And we probably want R_WASM_MEMORY_ADDR_SLEB64 and R_WASM_MEMORY_ADDR_I64 as new relocation types.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80769/new/
https://reviews.llvm.org/D80769
More information about the llvm-commits
mailing list