[PATCH] D81179: [flang] avoid GCC < 8 compiler failure after D80794

David Truby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 4 11:33:38 PDT 2020


DavidTruby accepted this revision.
DavidTruby added a comment.
This revision is now accepted and ready to land.

This looks good to me.

As an aside, I think this perfectly demonstrates why we should not force on Werror or have it on by default. We don't have public build bots for even the compilers we claim to support and seemingly innocent changes can cause spurious build failures for other users simply because we are forcing Werror on. And worse, at the moment we are forcing Werror on with no way to turn it off meaning these spurious errors can't even be avoided. This comment isn't intended in any way to block this patch; I just wanted to note it here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81179/new/

https://reviews.llvm.org/D81179





More information about the llvm-commits mailing list