[PATCH] D81055: [WebAssembly] Lower llvm.debugtrap properly

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 4 11:33:21 PDT 2020


tlively added a comment.

In D81055#2072648 <https://reviews.llvm.org/D81055#2072648>, @aheejin wrote:

> Yeah you're right. I was confused; Binaryen's DCE only removes the code after `unreachable` is unreachable. But doesn't `debugtrap` instruction expect the control flow to return? That's why I was wondering if we can translate `debugtrap` to `unreachable`.


`debugtrap` //allows// control flow to return. It is ok if it doesn't return or if it is lowered to something that can't return.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81055/new/

https://reviews.llvm.org/D81055





More information about the llvm-commits mailing list