[PATCH] D80803: [DebugInfo] Remove unnecessary flushes and add additional testing

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 4 11:33:20 PDT 2020


MaskRay accepted this revision.
MaskRay added a comment.

IIUC,

> 3. have raw_fd_ostream instances contructed with - (the stdout variant) actually use the outs() stream, rather than its own one - this will prevent potential weird situations where we have two independent streams with their own buffers both writing to stdout, and therefore potentially getting very weird interleaving, but I'm not sure of the knock-on effects of this yet.

has been resolved by D81078 <https://reviews.llvm.org/D81078>

> tied_raw_fd_ostream

The idea will be implemented in D81156 <https://reviews.llvm.org/D81156>.

This rebased patch looks good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80803/new/

https://reviews.llvm.org/D80803





More information about the llvm-commits mailing list