[PATCH] D80307: [mlir] Add a shape op that always returns a successful witness

[River Riddle via Phabricator via llvm-commits]

rriddle marked an inline comment as done.
rriddle added inline comments.
Herald added a subscriber: msifontes.


================
Comment at: mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td:589
+
+  ```mlir
+      %0 = shape.const_shape [1,2,3]
----------------
nit: Remove the indent inside of this block.


================
Comment at: mlir/lib/Dialect/Shape/IR/Shape.cpp:45
   }
+  if (auto witnessType = type.dyn_cast<WitnessType>()) {
+    return builder.create<ConstWitnessOp>(loc, type, value.cast<BoolAttr>());
----------------
nit: Remove trivial braces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80307/new/

https://reviews.llvm.org/D80307