[PATCH] D80643: [CodeMoverUtils] Move OrderedInstructions to CodeMoverUtils

[rithik sharma via Phabricator via llvm-commits]

RithikSharma added a comment.

In D80643#2057673 <https://reviews.llvm.org/D80643#2057673>, @nikic wrote:

> You don't need an actual OrderedInstructions class. You can simply make domTreeLevelBefore() a static function in CodeMoverUtils.cpp. Replace the localDominates() call with Instruction::comesBefore().


Moving OrderedInstructions functions to CodeMoverUtils.cpp and making them static doesn't allow the unittest to pass! The unittest requires the call of "dominates" and the only way to fulfill is to define "dominates" into CodeMoverUtils.h which is not the preferred step!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80643/new/

https://reviews.llvm.org/D80643