[PATCH] D81156: [Support] Create a tied stream class and use it for errs()

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Looks great!



================
Comment at: llvm/include/llvm/Support/raw_ostream.h:308
+  /// currently in the buffer.
+  virtual uint64_t current_pos() const = 0;
+
----------------
There is another `private` specifier above. You can avoid this `private`.


================
Comment at: llvm/include/llvm/Support/raw_ostream.h:525
 
-/// This returns a reference to a raw_fd_ostream for standard error. Use it
-/// like: errs() << "foo" << "bar";
+/// errs() - This returns a reference to a raw_ostream for standard error.
+/// Use it like: errs() << "foo" << "bar";
----------------
Don’t duplicate function or class name at the beginning of the comment.

http://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81156/new/

https://reviews.llvm.org/D81156