[PATCH] D80924: [CostModel] Use MaybeAlign in getMemoryOpCost

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 4 08:45:11 PDT 2020


gchatelet added a comment.

In D80924#2073798 <https://reviews.llvm.org/D80924#2073798>, @samparker wrote:

> > We should remove MaybeAlign entirely. Nothing is ever truly missing the alignment, and Align(1) is always a acceptable degenerate value.
>
> Okay, so for my case where TTIImpl can't pass the object to BasicTTI, I could just check whether alignment is assigned, and if not, then just pass Align(1)?


Yes, thx @arsenm for pointing this out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80924/new/

https://reviews.llvm.org/D80924





More information about the llvm-commits mailing list