[PATCH] D80838: [llvm-ar] Add more tests for errors in opening archives

[Sameer Arora via Phabricator via llvm-commits]

sameerarora101 updated this revision to Diff 268492.
sameerarora101 added a comment.

Separating permission and directory cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80838/new/

https://reviews.llvm.org/D80838

Files:
  llvm/test/tools/llvm-ar/error-opening-directory.test
  llvm/test/tools/llvm-ar/error-opening-permission.test
  llvm/test/tools/llvm-ar/print.test


Index: llvm/test/tools/llvm-ar/print.test
===================================================================
--- llvm/test/tools/llvm-ar/print.test
+++ llvm/test/tools/llvm-ar/print.test
@@ -68,7 +68,7 @@
 ## No archive:
 # RUN: not llvm-ar p 2>&1 \
 # RUN:   | FileCheck %s --check-prefix=NO-ARCHIVE
-# 
+#
 # NO-ARCHIVE: error: an archive name must be specified
 
 ## Archive does not exist:
Index: llvm/test/tools/llvm-ar/error-opening-permission.test
===================================================================
--- /dev/null
+++ llvm/test/tools/llvm-ar/error-opening-permission.test
@@ -0,0 +1,14 @@
+## Unsupported on windows as marking files "unreadable"
+## is non-trivial with chmod on windows.
+# UNSUPPORTED: system-windows
+
+# RUN: rm -rf %t && mkdir -p %t
+# RUN: echo file1 > %t/1.txt
+
+## No Permission:
+# RUN: llvm-ar rc %t/permission.b %t/1.txt
+# RUN: chmod 100 %t/permission.b
+# RUN: not llvm-ar p %t/permission.b 2>&1 | \
+# RUN:   FileCheck %s --check-prefix=NO-PERMISSION -DARCHIVE=%t/permission.b
+
+# NO-PERMISSION: error: error opening '[[ARCHIVE]]': {{[pP]}}ermission denied
Index: llvm/test/tools/llvm-ar/error-opening-directory.test
===================================================================
--- /dev/null
+++ llvm/test/tools/llvm-ar/error-opening-directory.test
@@ -0,0 +1,8 @@
+# RUN: rm -rf %t && mkdir -p %t
+
+## Passing in a directory:
+# RUN: mkdir -p %t/tmpDir
+# RUN: not llvm-ar p %t/tmpDir 2>&1 | \
+# RUN:    FileCheck %s --check-prefix=IS-DIR -DARCHIVE=%t/tmpDir
+
+# IS-DIR: error: error opening '[[ARCHIVE]]': {{[iI]}}s a directory


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80838.268492.patch
Type: text/x-patch
Size: 1596 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200604/92902733/attachment.bin>