[PATCH] D80837: [MLIR][SPIRV] Add flat, location, and noperspective decorations

[Lei Zhang via Phabricator via llvm-commits]

antiagainst added a comment.

Thanks @Hazem ! Just a few nits. Could you just name the test file as `decorations.mlir` to follow the terms in the spec?



================
Comment at: mlir/test/Dialect/SPIRV/Serialization/decorators.mlir:4
+spv.module Logical GLSL450 requires #spv.vce<v1.0, [Shader], []> {
+  // CHECK: spv.globalVariable {{@.*}} : !spv.ptr<vector<4xf32>, Input>
+  spv.globalVariable @var1 {location = 0 : i32} : !spv.ptr<vector<4xf32>, Input>
----------------
Acutally I think we should `// CHECK: location = 0: i32` instead of the `spv.globalVariable` here given that's the purpose of the test? :) 

Similarly for the rest: `// CHECK: no_perspective` , `// CHECK: flat`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80837/new/

https://reviews.llvm.org/D80837