[PATCH] D80382: [MC] Implement generating 64-bit debug info.

Thu Jun 4 05:27:26 PDT 2020

ikudrin abandoned this revision.
ikudrin marked 2 inline comments as done.
ikudrin added a comment.

In D80382#2069346 <https://reviews.llvm.org/D80382#2069346>, @dblaikie wrote:

> I know this wouldn't be DWARF compliant - but could you separate this into one patch per section. (the first patch could add a test case & just check the debug_abbrev section has correct DWARF64, the next one testing the debug_info, etc. (that is assuming llvm-dwarfdump can handle mixid DWARF32/DWARF64 sections) - it'd be easier to validate all the changes to each sections emission are being tested appropriately that way

I've prepared a series of patches starting with D81143 <https://reviews.llvm.org/D81143>. Please, take a look. So, I am abandoning this revision in favor of the new set.

================
Comment at: llvm/tools/llvm-mc/llvm-mc.cpp:391
+  if (MCOptions.Dwarf64) {
+    // DWARFv3 was the first standard where the 64-bit DWARF was described.
+    if (DwarfVersion < 3) {
----------------
jhenderson wrote:
> Nit: either "the 64-bit DWARF format" or simply "64-bit DWARF".
Thanks! Fixed in D81143.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80382/new/

https://reviews.llvm.org/D80382