[llvm] 21dadd7 - [DAGCombiner] avoid unnecessary indirection from SDNode/SDValue; NFCI

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 4 04:44:19 PDT 2020


Thanks, all! Sorry about the bug.
I saw that pattern on some FP nodes where it didn't seem necessary and went
overboard on the changes.
I'll add code comments and try to reduce to a minimal test, so we don't
make that mistake again.

On Thu, Jun 4, 2020 at 6:54 AM Tim Northover <t.p.northover at gmail.com>
wrote:

> On Thu, 4 Jun 2020 at 11:32, Hans Wennborg <hans at chromium.org> wrote:
> > See also https://bugs.llvm.org/show_bug.cgi?id=46194
> >
> > I think reverting for now would make sense.
>
> OK, I've done that:
>
> To github.com:llvm/llvm-project.git
>    c781e7370e9b..87e24c320089  master -> master
>
> It can easily be reapplied if we decide everywhere else is OK.
>
> Cheers.
>
> Tim.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200604/4fc94415/attachment.html>


More information about the llvm-commits mailing list