[PATCH] D78203: [VP,Integer,#2] ExpandVectorPredication pass

Simon Moll via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 4 02:40:26 PDT 2020


simoll marked an inline comment as done.
simoll added inline comments.


================
Comment at: llvm/lib/IR/IntrinsicInst.cpp:309
     }
-    if (match(VLParam, m_VScale(DL))) {
-      return ParamFactor;
-    }
-    return false;
+    return match(VLParam, m_VScale(DL));
   }
----------------
This unrelated change fixes a bug (`ParamFactor` does not make sense as a return value here and is not initialized!). I'll push a fix in a separate commit along with a test for this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78203/new/

https://reviews.llvm.org/D78203





More information about the llvm-commits mailing list