[PATCH] D81056: [Support] Replace 'DisableColors' boolean with 'ColorMode' enum

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, assuming the unit test works.



================
Comment at: llvm/unittests/Support/WithColorTest.cpp:39
+    WithColor(OS, HighlightColor::Error, ColorMode::Enable) << "test";
+    EXPECT_EQ("\x1B[0;1;31mtest\x1B[0m", OS.str());
+  }
----------------
JDevlieghere wrote:
> Not sure if this works on Windows, I'll have to double check. 
I tried checking, but had trouble applying the parent patch for some reason. Not sure why, sorry.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81056/new/

https://reviews.llvm.org/D81056