[PATCH] D81005: [yaml2obj] - Add a way to exclude specified sections from the section header.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with nits.



================
Comment at: llvm/test/tools/yaml2obj/ELF/section-headers-exclude.yaml:245
+
+## Case D.2: check we report an error when a relocatable section has the Info field which
+##           points to an excluded section.
----------------
grimar wrote:
> jhenderson wrote:
> > has the -> has a
> has **an**?
Oops, yeah, thanks :)


================
Comment at: llvm/test/tools/yaml2obj/ELF/section-headers-exclude.yaml:2
+## Check how we can use the "Excluded" key of the "SectionHeaderTable" tag to exclude
+## entries from the section header table..
+
----------------
Nit: too many full stops


================
Comment at: llvm/test/tools/yaml2obj/ELF/section-headers-exclude.yaml:327-328
+
+## Case F.2: check we report an error when the group section is linked
+##           with an excluded section explicitly.
+# RUN: not yaml2obj %s --docnum=13 -o /dev/null 2>&1 | \
----------------
linked with -> linked to

(it's a one-way relationship typically, so I think this phrasing expresses it better)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81005/new/

https://reviews.llvm.org/D81005