[PATCH] D80874: [llvm-dwarfdump] Add a table header for -debug-line -verbose output
    James Henderson via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Jun  4 01:02:32 PDT 2020
    
    
  
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
Thanks for the update. LGTM, with nit.
================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test:41-42
 # FIRST:        debug_line[0x00000000]
-# VERBOSE:      DW_LNE_set_address (0x000000000badbeef)
+# VERBOSE:                  Address            Line   Column File   ISA Discriminator Flags
+# VERBOSE-NEXT:             ------------------ ------ ------ ------ --- ------------- -------------
+# VERBOSE-NEXT: DW_LNE_set_address (0x000000000badbeef)
----------------
jhenderson wrote:
> Since the rest of this test doesn't line up with the header here, I'd just get rid of the extra spacing. The test looks odd to me with it.
Looks like this hasn't been addressed still?
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80874/new/
https://reviews.llvm.org/D80874
    
    
More information about the llvm-commits
mailing list