[PATCH] D81124: lld: use modern library search ordering

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/MachO/Driver.cpp:79
+  std::string archive = (llvm::Twine("lib") + name + ".a").str();
+  llvm::SmallString<260> location;
 
----------------
gkm wrote:
> Nit: I'd rather see `PATH_MAX`, but literal ints like this are the norm.
Do we omit `llvm::` for commonly used LLVM ADT/Support classes?


================
Comment at: lld/test/MachO/link-search-order.s:11
+
+# REQUIRES: x86
+
----------------
Move it to the top


================
Comment at: lld/test/MachO/link-search-order.s:21
+_main:
+  movl $0x2000004, %eax                                # write()
+  mov $1, %rdi                                 # stdout
----------------
Looks misaligned.

You may need to convert some tabs to spaces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81124/new/

https://reviews.llvm.org/D81124