[PATCH] D81045: [MLIR] Modify HasParent trait to allow one of several op's as a parent

[Rahul Joshi via Phabricator via llvm-commits]

jurahul added a comment.

@rriddle and others, I have extended the isa<> function to be a variadic template, but that is causing a ripple effect of several places breaking where isa<> is used as a predicate and instantiate using something like:

  if (SCEVExprContains(T, isa<SCEVUnknown, const SCEV *>))

with the new isa<> definition, such code does not work as is and needs to updated. I am working on fixing all references, but I am wondering if this will cause churn in out-of-tree code that uses LLVM as well. I cannot call the new functions `is_one_of` as there already exists a struct of this type with a different meaning. Another option is to name it `isa_one_of` but that does not read well I think. Do you agree with extending isa<> as in this change? If so, I can continue patching the remaining places (once I setup a windows build).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81045/new/

https://reviews.llvm.org/D81045