[PATCH] D79954: [mlir] [VectorOps] Implement vector.create_mask lowering to LLVM IR

[Aart Bik via Phabricator via llvm-commits]

aartbik marked 2 inline comments as done.
aartbik added inline comments.
Herald added a project: MLIR.


================
Comment at: mlir/lib/Dialect/Vector/VectorTransforms.cpp:1239
 
+class CreateMaskOpLowering : public OpRewritePattern<vector::CreateMaskOp> {
+public:
----------------
rriddle wrote:
> Can you add comments to what the expected output is given a mask input? Lowerings should really be documented.
Yes of course. Not sure how I missed that when writing this CL.... Fix coming up....


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79954/new/

https://reviews.llvm.org/D79954