[PATCH] D81113: lld: add basic static library search

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd marked an inline comment as done.
compnerd added inline comments.


================
Comment at: lld/test/MachO/static-link.s:17-20
+  movl $0x2000004, %eax                                # write()
+  mov $1, %rdi                                 # stdout
+  leaq _goodbye_world(%rip), %rsi
+  mov $15, %rdx                                        # length
----------------
int3 wrote:
> one more nit: would be nice to clean up the indentation of these comments
Oh, they are just aligned (with hard tabs as is the general pattern with assembly files), I can change them to be indented with space instead.


================
Comment at: lld/test/MachO/static-link.s:25-30
+# CHECK: SYMBOL TABLE:
+# CHECK: {{0+}}[[ADDR:[0-9a-f]+]] g     O __TEXT,__cstring _goodbye_world
+
+# CHECK: Disassembly of section __TEXT,__text
+# CHECK-LABEL: <_main>:
+# CHECK: leaq {{.*}}(%rip), %rsi   # [[ADDR]] <_goodbye_world>
----------------
int3 wrote:
> nit: we usually put these right after their respective FileCheck invocation line (so after line 11 in this file)
Hmm, most of LLVM IIRC also tends to just group the expectations and the RUN lines so that its easier to understand the full flow of the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81113/new/

https://reviews.llvm.org/D81113