[PATCH] D80676: [mlir][gpu] Introduce mlir-rocm-runner.

[Zhuoran Yin via Phabricator via llvm-commits]

jerryyin accepted this revision.
jerryyin added a comment.

LGTM



================
Comment at: mlir/tools/mlir-rocm-runner/mlir-rocm-runner.cpp:71
+                                       cl::value_desc("AMDGPU ISA version"),
+                                       cl::init("gfx900"));
+
----------------
whchung wrote:
> jerryyin wrote:
> > Adding a TODO regarding on supporting other target chips?
> Other targets such as `gfx906` `gfx908` can already work via this option. I'll add a TODO to detect native AMD GPU ISA version on the system.
Thanks for clarifying


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80676/new/

https://reviews.llvm.org/D80676