[PATCH] D54368: RegAllocFast: Record internal state based on register units

[Matt Arsenault via Phabricator via llvm-commits]

arsenm updated this revision to Diff 268294.
arsenm added a comment.
Herald added subscribers: kerbowa, hiraditya.

Rebase and fix the one remaining failure in test/CodeGen/X86/2010-06-28-FastAllocTiedOperand.ll, so now this patch no longer introduces an intermediate broken step before D52010 <https://reviews.llvm.org/D52010>.

The problem was the spilling was dropped from handleThroughOperands in the physdef collision loop. Restored the definePhysReg call with the new regunit iterator checks instead of using the reg alias iterator


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54368/new/

https://reviews.llvm.org/D54368

Files:
  llvm/lib/CodeGen/RegAllocFast.cpp
  llvm/test/CodeGen/AArch64/arm64-fast-isel-conversion-fallback.ll
  llvm/test/CodeGen/AArch64/arm64-fast-isel-conversion.ll
  llvm/test/CodeGen/AArch64/arm64-vcvt_f.ll
  llvm/test/CodeGen/AArch64/fast-isel-sp-adjust.ll
  llvm/test/CodeGen/AMDGPU/indirect-addressing-term.ll
  llvm/test/CodeGen/AMDGPU/partial-sgpr-to-vgpr-spills.ll
  llvm/test/CodeGen/AMDGPU/spill-m0.ll
  llvm/test/CodeGen/AMDGPU/wwm-reserved.ll
  llvm/test/CodeGen/ARM/legalize-bitcast.ll
  llvm/test/CodeGen/Mips/GlobalISel/llvm-ir/fptosi_and_fptoui.ll
  llvm/test/CodeGen/Mips/atomic-min-max.ll
  llvm/test/CodeGen/Mips/atomic.ll
  llvm/test/CodeGen/Mips/implicit-sret.ll
  llvm/test/CodeGen/PowerPC/addegluecrash.ll
  llvm/test/CodeGen/PowerPC/vsx.ll
  llvm/test/CodeGen/X86/2009-04-14-IllegalRegs.ll
  llvm/test/CodeGen/X86/atomic-unordered.ll
  llvm/test/CodeGen/X86/atomic32.ll
  llvm/test/CodeGen/X86/atomic64.ll
  llvm/test/CodeGen/X86/avx-load-store.ll
  llvm/test/CodeGen/X86/avx512-mask-zext-bugfix.ll
  llvm/test/CodeGen/X86/crash-O0.ll
  llvm/test/CodeGen/X86/extend-set-cc-uses-dbg.ll
  llvm/test/CodeGen/X86/fast-isel-nontemporal.ll
  llvm/test/CodeGen/X86/pr1489.ll
  llvm/test/CodeGen/X86/pr27591.ll
  llvm/test/CodeGen/X86/pr30430.ll
  llvm/test/CodeGen/X86/pr30813.ll
  llvm/test/CodeGen/X86/pr32241.ll
  llvm/test/CodeGen/X86/pr32284.ll
  llvm/test/CodeGen/X86/pr32340.ll
  llvm/test/CodeGen/X86/pr32345.ll
  llvm/test/CodeGen/X86/pr32451.ll
  llvm/test/CodeGen/X86/pr34592.ll
  llvm/test/CodeGen/X86/pr39733.ll
  llvm/test/CodeGen/X86/pr44749.ll
  llvm/test/CodeGen/X86/regalloc-fast-missing-live-out-spill.mir
  llvm/test/CodeGen/X86/swift-return.ll
  llvm/test/CodeGen/X86/swifterror.ll
  llvm/test/DebugInfo/X86/op_deref.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54368.268294.patch
Type: text/x-patch
Size: 238902 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200603/9c3e50a9/attachment-0001.bin>