[PATCH] D74362: Cheap Function Entry Instrumentation for Dead Code Detection

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added a comment.

In D74362#2065182 <https://reviews.llvm.org/D74362#2065182>, @dberris wrote:

> In D74362#2065160 <https://reviews.llvm.org/D74362#2065160>, @MaskRay wrote:
>
> > A high-level comment: does this pass achieve something not doable with XRay, a mature instrumentation framework in LLVM?
>
>
> All of this can be implemented as a runtime plugged into the XRay framework. If you just want to see which functions have been called (or executed) in this documentation I have an example of how to do precisely what this is attempting to do:
>
> https://reviews.llvm.org/D56244
>
> That implementation works for basic and FDR modes.


Thanks for the link.
The code size overhead of this instrumentation is 12bytes per function(adrp+strb+1byte in global array) + 13bytes per module. how does this compare to xray instrumentation?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74362/new/

https://reviews.llvm.org/D74362