[PATCH] D80406: [LLD][ThinLTO] A switch to allow compilation of only one module.

[Hongtao Yu via Phabricator via llvm-commits]

hoyFB marked 2 inline comments as done.
hoyFB added a comment.

Addressed feedbacks.



================
Comment at: lld/ELF/LTO.cpp:143
+  for (auto &name : config->thinLTOModulesToCompile)
+    c.ThinLTOModulesToCompile.emplace_back(name);
+
----------------
MaskRay wrote:
> `push_back`. `emplace_back` makes people wonder whether you use a smart constructor
`emplace_back`  is needed since `name` is not a `std::string` but a `StringRef`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80406/new/

https://reviews.llvm.org/D80406