[PATCH] D77172: Heat Coloring (3/3): Adding Heat Functionality to CallPrinter

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 3 09:18:53 PDT 2020


davidxl added inline comments.


================
Comment at: llvm/lib/Analysis/CallPrinter.cpp:79
+      if (!CallMultiGraph)
+        for (auto pairF = F; pairF != M->getFunctionList().end(); ++pairF) {
+          uint64_t Counter = getNumOfCalls(*F, *pairF);
----------------
Is this loop needed? Can you just check the *iter, *F pair? -- the enclosing loop should cover all caller,callee pairs in the module.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77172/new/

https://reviews.llvm.org/D77172





More information about the llvm-commits mailing list