[PATCH] D81094: [FileCheck] Implement equality operators for ExpressionValue.

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 3 08:44:57 PDT 2020


thopre added inline comments.


================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:487-488
+  EXPECT_TRUE(ExpressionValue(-2) != ExpressionValue(6));
+  EXPECT_FALSE(ExpressionValue(-7) == ExpressionValue(7));
+  EXPECT_TRUE(ExpressionValue(-7) != ExpressionValue(7));
+  EXPECT_FALSE(ExpressionValue(4) == ExpressionValue(-4));
----------------
Maybe also test numbers which would have the same representation when cast to unsigned, e.g.

UINT64_MAX and -1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81094/new/

https://reviews.llvm.org/D81094





More information about the llvm-commits mailing list