[PATCH] D80989: [DebugInfo] Print non-verbose output at some point as verbose output

Wed Jun 3 07:06:12 PDT 2020

jhenderson requested review of this revision.
jhenderson marked an inline comment as done.
jhenderson added a comment.

Could I get another review of this now? I think it solves the problems of the previous version.

================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:923-924
         }
+        if (Verbose) // FIXME: Don't print this newline.
+          *OS << "\n";
         State.appendRowToMatrix();
----------------
This is one of several places where new line printing seems incorrect. I am preparing a patch to fix this, and leaving this code in for now to minimise the number of behaviour changes in this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80989/new/

https://reviews.llvm.org/D80989