[PATCH] D81051: [ObjectYAML][ELF] Let the endianness of DWARF sections be inferred from FileHeader.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM.



================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-aranges.yaml:7-8
 
-# RUN: yaml2obj --docnum=1 -DENDIAN=ELFDATA2MSB %s -o %t1.o
-# RUN: llvm-readobj --sections --section-data %t1.o | \
+# RUN: yaml2obj --docnum=1 -DENDIAN=ELFDATA2MSB %s -o %t.be.o
+# RUN: llvm-readobj --sections --section-data %t.be.o | \
 # RUN:   FileCheck %s -DADDRALIGN=1 --check-prefixes=DWARF-BE-DEFAULT
----------------
Higuoxing wrote:
> jhenderson wrote:
> > You're welcome to continue to use %t1.o and %t2.o etc if you want - my previous suggestion in this area was more by way of example. What you have here is fine too though.
> `%t.be.o` and `%t.le.o` belong to the test case (a). I want to avoid having something like:
> 
> ```
> # RUN: yaml2obj --docnum=1 %s -o %t1.o ## Big endian case.
> ...
> # RUN: yaml2obj --docnum=1 %s -o %t2.o ## Little endian case.
> ...
> # RUN: yaml2obj --dconum=2 %s -o %t3.o
> ```
Makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81051/new/

https://reviews.llvm.org/D81051