[PATCH] D80738: [llvm][SVE] IR intrinsic for LD1RO.

Francesco Petrogalli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 3 07:06:08 PDT 2020


fpetrogalli added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-ld1ro.ll:4
+;
+; LD1ROB
+;
----------------
sdesmalen wrote:
> perhaps somewhat unrelated, but I see that llvm/test/CodeGen/AArch64/sve-intrinsics-loads.ll contains the ld1rq tests. (Oddly enough that file also contains tests for ldnt1, but nothing else)
> Maybe we can merge the ld1r* tests into one file?
I'd rather keep the ld1ro and ld1rq tests separate. I see more value in having more smaller test files than fewer big tests files, it make it easier to me to isolate implementation, reviews and possible failures.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80738/new/

https://reviews.llvm.org/D80738





More information about the llvm-commits mailing list