[PATCH] D80972: [ObjectYAML][DWARF] Support emitting the .debug_aranges section in ELFYAML.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one nit.

Don't forget to mark comments as "Done" before posting your latest update. The "Done" marks will be submitted when you post the diff, and it's then easy to see any comments that might have been missed/not addressed etc.



================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-aranges.yaml:11-24
+#       DWARF-BE-HEADER:   Index: 1
+#  DWARF-BE-HEADER-NEXT:   Name: .debug_aranges (1)
+#  DWARF-BE-HEADER-NEXT:   Type: SHT_PROGBITS (0x1)
+#  DWARF-BE-HEADER-NEXT:   Flags [ (0x0)
+#  DWARF-BE-HEADER-NEXT:   ]
+#  DWARF-BE-HEADER-NEXT:   Address: 0x0
+#  DWARF-BE-HEADER-NEXT:   Offset: 0x40
----------------
Nit: there's an extra two spaces of indentation here that aren't really needed as far as I can tell, so you can remove them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80972/new/

https://reviews.llvm.org/D80972