[PATCH] D81051: [ObjectYAML][ELF] Let the endianness of DWARF sections be inferred from FileHeader.

Wed Jun 3 02:43:08 PDT 2020

jhenderson added a comment.

Same comments generally apply to this test case as the big endian one from D80972 <https://reviews.llvm.org/D80972>. Otherwise, this looks fine.

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-aranges.yaml:7-8

-# RUN: yaml2obj --docnum=1 -DENDIAN=ELFDATA2MSB %s -o %t1.o
-# RUN: llvm-readobj --sections --section-data %t1.o | \
+# RUN: yaml2obj --docnum=1 -DENDIAN=ELFDATA2MSB %s -o %t.be.o
+# RUN: llvm-readobj --sections --section-data %t.be.o | \
 # RUN:   FileCheck %s -DADDRALIGN=1 --check-prefixes=DWARF-BE-DEFAULT
----------------
You're welcome to continue to use %t1.o and %t2.o etc if you want - my previous suggestion in this area was more by way of example. What you have here is fine too though.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81051/new/

https://reviews.llvm.org/D81051