[PATCH] D80972: [ObjectYAML][DWARF] Support emitting the .debug_aranges section in ELFYAML.

Wed Jun 3 02:10:20 PDT 2020

jhenderson added inline comments.

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-aranges.yaml:9
+# RUN: llvm-readobj --sections --section-data %t1.o | \
+# RUN:   FileCheck %s -DADDRALIGN=1 --check-prefixes=DWARF-BE-DEFAULT
+
----------------
As you only have one check prefix, you can use --check-prefix like before, if you want.

I'm slightly surprised the code naturally produces big endian output!

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-aranges.yaml:48
+##                                 |        |   |        +- AddrSize (1-byte) 0x08
+##                                 |        |   +--- ---- CuOffset (4-byte) 0x65
+##                                 |        +--- Version (2-byte) 0x02
----------------
Nit: I'd get rid of the space in the dashes on this line.

Same sort of comment on other lines below.

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-aranges.yaml:76
+      CuOffset: 0
+      AddrSize: 0x08
+      SegSize:  0x00
----------------
Looks like you haven't addressed my earlier comment about making the tables different address sizes. I don't think the address size should have to match the target's address size, if not desired.

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-aranges.yaml:79-80
+      Descriptors:
+        - Address: 0x0000000000001234
+          Length:  0x20
+    - Length:
----------------
It's probably a good idea for at least one table to have multiple `Descriptor` entries.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80972/new/

https://reviews.llvm.org/D80972