[PATCH] D80377: [flang] Google test infrastructure support for unittests

sameeran joshi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 3 01:36:13 PDT 2020


sameeranjoshi marked 2 inline comments as done.
sameeranjoshi added inline comments.


================
Comment at: flang/runtime/io-error.cpp:10
 #include "io-error.h"
-#include "config.h"
 #include "magic-numbers.h"
----------------
tskeith wrote:
> Is this supposed to be part of your change?
Yes, out-of-tree builds fail with this include.
Also see this commit addressing the same
https://github.com/flang-compiler/f18-llvm-project/commit/4069068c997812c1c8ef6434a5e630603c7232e0



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80377/new/

https://reviews.llvm.org/D80377





More information about the llvm-commits mailing list