[PATCH] D80838: [llvm-ar] Add more tests for errors in opening archives

Wed Jun 3 00:30:53 PDT 2020

jhenderson requested changes to this revision.
jhenderson added a comment.
This revision now requires changes to proceed.

According to the pre-merge checks, the new test is failing. Please review the logs and fix. It looks like the test may not work on some systems.

================
Comment at: llvm/test/tools/llvm-ar/error-opening-archive.test:9-10
+# RUN: chmod 100 %t/permission.b
+# RUN: not llvm-ar p %t/permission.b 2>&1 \
+# RUN:   | FileCheck %s --check-prefix=NO-PERMISSION -DARCHIVE=%t/permission.b
+
----------------
Nit: my personal preference is for continuation lines to be formatted as follows:

```
# RUN: not llvm-ar p %t/permission.b 2>&1 | \
# RUN:   FileCheck %s --check-prefix=NO-PERMISSION -DARCHIVE=%t/permission.b
```

The idea is that from the first line, it is clear that the next line is a new command, rather than just a continuation of the options for the instruction on that line, and from the second line, the extra indentation makes clear it is a continuation of the first line.

Same applies below.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80838/new/

https://reviews.llvm.org/D80838